Skip to content

Bump sm3 & add crates to skip list#11535

Open
cakebaker wants to merge 2 commits intouutils:mainfrom
cakebaker:bump_sm3
Open

Bump sm3 & add crates to skip list#11535
cakebaker wants to merge 2 commits intouutils:mainfrom
cakebaker:bump_sm3

Conversation

@cakebaker
Copy link
Copy Markdown
Contributor

@cakebaker cakebaker commented Mar 28, 2026

This PR bumps sm3 from 0.4.2 to 0.5.0 and adds the crates digest, crypto-common, and block-buffer to the skip list in deny.toml.

Closes #11531

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 28, 2026 •
edited
Loading

Merging this PR will not alter performance

✅ 302 untouched benchmarks
⏩ 46 skipped benchmarks1

Comparing cakebaker:bump_sm3 (864ccfd) with main (15f57d0)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 28, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/misc/io-errors is no longer failing!
Note: The gnu test tests/cut/bounded-memory is now being skipped but was previously passing.
Note: The gnu test tests/tail/pipe-f is now being skipped but was previously passing.
Congrats! The gnu test tests/unexpand/bounded-memory is now passing!

@xtqqczze
Copy link
Copy Markdown
Contributor

xtqqczze commented Mar 28, 2026 •
edited
Loading

@cakebaker As per #11492 (comment), should we wait until we can fully update to digest v0.11?:

$ cargo tree --invert digest --depth 1 --target all
digest v0.10.7
├── crc-fast v1.9.0
├── md-5 v0.10.6
├── sha1 v0.10.6
│   [dev-dependencies]
├── sha2 v0.10.9
├── sha3 v0.10.8
├── sm3 v0.4.2
└── uucore v0.8.0 (/Users/matthew/repos/xtqqczze/uutils-coreutils/src/uucore)
    [dev-dependencies]

The only dependencies yet to be updated to digest v0.11 are:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cakebaker @xtqqczze